MESH API interface#119
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #119 +/- ##
==========================================
+ Coverage 88.74% 94.72% +5.98%
==========================================
Files 28 44 +16
Lines 604 1480 +876
==========================================
+ Hits 536 1402 +866
- Misses 68 78 +10
Continue to review full report at Codecov.
|
murd0
approved these changes
Mar 10, 2020
murd0
left a comment
murd0
left a comment
Contributor
There was a problem hiding this comment.
Perfect. Thanks for the time you've spent on this.
Merged
georgeRobertson
pushed a commit
that referenced
this pull request
Apr 20, 2020
* MESH API interface (#119) * Migrate across MESH api connection scripts and teses * Add MESH to documentation and adding example usage * Include dataclasses in requirements for py3.6 * Update tests to match new return structure * Fix flake8 issues * Add tests for early halt if entire inbox errors * Additional error test cases to get coverage to 100 * Various header fixes due to undocumented API behaviour Co-authored-by: Chris Daniels <CHDA5@hscic.gov.uk> * v0.2.3 * Change test import to reflect reindexing Co-authored-by: Khoross <31031340+Khoross@users.noreply.github.com> Co-authored-by: Chris Daniels <CHDA5@hscic.gov.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Y] The commit message is clear and concise
[Y] Test for the changes have been added and reviewed
[Y] Documentation has been added to all new features and edited code has had documentation reviewed
Adds a client class for interacting with MESH (Message Exchange for Social Care and Health) via its API. The implements all MESH API routes as of v1.18 of the MESH API, as well as a helper method for the task of downloading all messages in an inbox.